Chief Delphi

Chief Delphi (http://www.chiefdelphi.com/forums/index.php)
-   C/C++ (http://www.chiefdelphi.com/forums/forumdisplay.php?f=183)
-   -   Please don't reformat WPILib code during build season (http://www.chiefdelphi.com/forums/showthread.php?t=113033)

kenfox 08-02-2013 11:46

Please don't reformat WPILib code during build season
 
I'm not sure who is working on WPILib, but it would be very nice if the mid-season releases didn't change source code formatting. I've been trying to keep up with bugs and fixes, but the cosmetic changes make the fixes harder to find.

Thank you for the source code releases by the way. It's incredibly valuable to be able to see how WPILib works rather than it being a black box.

virtuald 08-02-2013 12:15

Re: Please don't reformat WPILib code during build season
 
Quote:

Originally Posted by kenfox (Post 1229884)
I'm not sure who is working on WPILib, but it would be very nice if the mid-season releases didn't change source code formatting. I've been trying to keep up with bugs and fixes, but the cosmetic changes make the fixes harder to find.

I'm confused as to why you're keeping up with bugs and fixes? I mean it's great to be aware of them... but if you just don't use the previous version and install the latest binary from them, you're set to go...

kenfox 08-02-2013 13:54

Re: Please don't reformat WPILib code during build season
 
Quote:

Originally Posted by virtuald (Post 1229900)
but if you just don't use the previous version and install the latest binary from them, you're set to go...

If we know what changed we can predict how our robot is affected. We can also review previously discarded approaches or learn something new.

On a more personal level, I'd like to be a part of the community. This is an incredible Open Source project with active and inspired development. In order for me to be effective, it's my responsibility to understand the code. I'm asking for a professional courtesy to help make that job easier.

You can see the changes in the latest WPILib here: https://github.com/FRC3322/WPILib/co...688e34f4b13ee1

The green lines are additions; the red lines deletions.

jwakeman 08-02-2013 14:20

Re: Please don't reformat WPILib code during build season
 
After looking at your diff I see that you are just making the point that if (for example) a curly brace is moved from right after the method arguments to the next line it shows up as a difference which makes it more difficult to determine what functionaly changed in the code.

Not sure if you are aware but you can track (and submit) bugs and their fixes on the FIRST Forge site.

http://firstforge.wpi.edu/sf/tracker....wpilib_c_bugs


All times are GMT -5. The time now is 12:55.

Powered by vBulletin® Version 3.6.4
Copyright ©2000 - 2017, Jelsoft Enterprises Ltd.
Copyright © Chief Delphi