Thread: Code Check
View Single Post
  #2   Spotlight this post!  
Unread 13-02-2011, 20:45
Wolfgang Wolfgang is offline
Registered User
AKA: Mehmed
FRC #1245 (Shazbots)
Team Role: Programmer
 
Join Date: Oct 2009
Rookie Year: 2010
Location: Denver
Posts: 47
Wolfgang is an unknown quantity at this point
Re: Code Check

There are a few things I notice.

- Generally, you should be defining refnums in the begin.vi portion of the code.

- There should be no need to use close vi's on the motors or analog stuff.

- It appears in motor.vi that all the motors have the same PWM channel. This means only one motor. Set only one to PWM 1, others to 2,3, etc.

- It is unclear to me why you are taking voltage info and from where, but since I do not know exactly how your bot works, just let it be.

My team's bot works similarly but with only two motors: one stationary, and one moving up and down while moving another part of our arm.

These were not big things that would be hard to find, but I hope it helps!
Reply With Quote