Thread: Check My Code
View Single Post
  #4   Spotlight this post!  
Unread 20-03-2011, 15:36
Alan Anderson's Avatar
Alan Anderson Alan Anderson is offline
Software Architect
FRC #0045 (TechnoKats)
Team Role: Mentor
 
Join Date: Feb 2004
Rookie Year: 2004
Location: Kokomo, Indiana
Posts: 9,112
Alan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond repute
Re: Check My Code

Quote:
Originally Posted by jhellr13 View Post
I have attached my new version, if you can just take a glance at it.
At first glance, it seems okay. A deeper look reveals a couple of things I would have done differently, such as getting the Arm relay reference only once and passing the reference through the sequence to each relay set function, but that's not a major issue. I'm also a little concerned that you might not be driving your motors hard enough, with 0.3 seeming a little low.
Reply With Quote