View Single Post
  #1   Spotlight this post!  
Unread 20-12-2011, 08:36
gixxy's Avatar
gixxy gixxy is offline
Programming and Arduino Mentor
AKA: Gustave Michel III
FRC #3946 (Tiger Robotics)
Team Role: Mentor
 
Join Date: Nov 2011
Rookie Year: 2012
Location: Ruston, LA
Posts: 207
gixxy is on a distinguished road
Re: Would someone review my code?

Explation my use of a ControlMap interface: Its for if you may have more than one controls setup. Since right now i only have one ControlBoard class it is fairly useless, but if say I wanted to make it so that I could switch between Arcade and Tank Drive, It would come in handy. I can just re-init the same ControlMap interface in Controller using the other ControlBoard's object.


did i really use protected on the singleton classes constructors...... (I wrote it, and the getInstance() method once then copy and pasted it, changing the class names). Yep, derp on my part.

As with packages, I normally would have used them, but this was simple enough that it didn't matter.

With masterControl() and Controller.... I changed it when I realized I had called the class TheUser and the Method masterControlProgram().... I felt I had let my geek get away from me too much.....

also, I did take a look at the command based template, and personally haven't taken to it yet, I prefer it being open ended. I'm sure once I actually use it I will feel differently, but for now I wrote it with the template I felt I liked best.

And in any case: Thanks, some very good information.
Reply With Quote