View Single Post
  #2   Spotlight this post!  
Unread 20-02-2012, 01:30
johnmaguire2013's Avatar
johnmaguire2013 johnmaguire2013 is offline
Harps On Websites
AKA: John Maguire
FRC #3322 (Eagle Imperium)
Team Role: Webmaster
 
Join Date: Jan 2011
Rookie Year: 2011
Location: Ann Arbor, MI
Posts: 74
johnmaguire2013 is an unknown quantity at this point
Re: Lightning Robotics' Website

Quote:
Originally Posted by quinxorin View Post
Well, I never thought I would write 8442 lines of PHP code in my entire life, let alone on one project, but apparently I did.

www.lightningrobotics.com


Tell me what you think!

Couple features I'm really proud of:
The Lightning Robotics Match Results Retrieval System
The mobile site
The Team Lessons Library
Wow, very nice. One of my favorite websites I've seen so far (besides my own of course -- have I told you tat my very best, greatest feature, out of all of my great features, is that I'm humble?) on here. I haven't downloaded the script you linked yet, so I can't speak to your coding style or ability, but the site looks very good (nice with the mobile site too.) My only suggestion really is to perhaps find a slightly nicer color scheme on the eyes, or create your own, more sophisticated design in Photoshop (a perfect design can be found on AdamBots.com's website, for inspiration.) Definitely the least of your worries tough.

I applaud developers who take standards seriously, as many seem to pass them up, so good job with the CSS/XHTML.

And just took a look at your library now... overall coding style looks decent (just skimmed it,) though my OCD nature doesn't like the inconsistencies in brace style. Also, best practice with libraries is usually to return data, not HTML, and allow the developer to implement it how they like.

I like the content on the site, and the amount of Resources you offer up for other teams. Very useful.

I might rename the Forums link to Members Area or something similar, so passers-by don't get confused. (This page says it's only for team members.)

Lastly, a news system might be nice. Especially if you can implement it into a particular forum on your private section, it would make it easy for users to post. An easy MySQL SELECT `content_field`, `author_field`, `posted_field` FROM `table` WHERE `forum_id`=integer_id, and formatting some stuff (also pagination perhaps.) BBCode -> HTML isn't too hard with some easy Regex.

Once again, a terrific site. Very nice.