Quote:
Originally Posted by subrc
Your website looks amazing, and nice job using HTML5 too!
That said, you might want to see how your HTML outline looks from time to time. Here's what your outline looks like right now:
http://gsnedders.html5.org/outliner/...nerobotics.org
There are a lot of untitled sections in your document. You can easily title any section in HTML5 by giving it an h1 element. The outermost section is the body element. It would make sense to make the title of the body the same as the title of the website as a whole ("Eagle Imperium"). And of course, you can just set all these h1 elements to not display using CSS.
I had a couple really picky issues with spacing, too. h1 elements don't have margins, and you sometimes have empty p elements between paragraphs. I also really wish the margin on paragraphs was 1em and not .5.
Of course, I'm only making such meticulous comments because you guys did a great job overall. It's nice to see a team taking its website seriously. |
Thank you for the comments.
Ah yes, a friend of mine, another student on the team, did the initial design and implemented it into HTML initially, with some bugs and not all the features done, and I then implemented it into WordPress, and him and I have continued to add slight features. I wasn't around when the initial bit got done and hence all the headers I haven't noticed.
I appreciate the link with the outline, and I will fix that too. However, I am slightly confused by your thought of using <h1> to title things and then setting it to display as none. While I do like to be semantically correct, this seems like a weird little hack to me. I've also heard that you should only use one <h1> per page. I will do some more investigating and Googling and then modify it as such.
Thank you for the comment.
EDIT - And on the topic of being symantically correct, it makes most sense (I thought) to do this with headers.
1. Eagle Imperium - FIRST 3322 (or similar)
2. News
3. News Title
4. Titles within news post
3. News Title #2
3. News Title #3
I don't think we are doing that as it currently stands, and I should probably at least fix that, but that's how I've always seen the whole semantics thing.
As for the spacing, that's all the other kid as he did the actual design bit, I mostly just do the JS, styling it some, implementing it into WordPress, etc. I will definitely check out how it looks with the margins you suggested and talk to him. We are very open to suggestions like this and I really appreciate it.
The empty <p> elements are due either to one of two things: WordPress being funky with the way it handles paragraphs, or the fact that before I was on the website team, a lot of Google Sites content was converted over to WordPress. I've been trying to systematically go through and edit the Google Sites pages as they have a lot of oddities, such as random divs (sometimes unclosed), empty headings, paragraphs, etc. If there are a few pages you noticed this on specifically that you could give me a link or page title to? I'd really appreciate it.
Thank you again for all your comments.