View Single Post
  #5   Spotlight this post!  
Unread 11-01-2013, 12:35
RyanN's Avatar
RyanN RyanN is offline
RyanN
AKA: Ryan Nazaretian
FRC #4901 (Garnet Squadron)
Team Role: Mentor
 
Join Date: Jun 2006
Rookie Year: 2005
Location: Columbia, SC
Posts: 1,126
RyanN has a reputation beyond reputeRyanN has a reputation beyond reputeRyanN has a reputation beyond reputeRyanN has a reputation beyond reputeRyanN has a reputation beyond reputeRyanN has a reputation beyond reputeRyanN has a reputation beyond reputeRyanN has a reputation beyond reputeRyanN has a reputation beyond reputeRyanN has a reputation beyond reputeRyanN has a reputation beyond repute
Re: Do my Vi's look alright so far?

Everything said above sounds like good recommendations. Greg is correct (of course... he works for NI!) about the blue numbers (non-floating point number). LabVIEW will automatically coerce the number to the correct value. That's what the little red dot means... it's a coercion dot. It's bad practice to do this though, especially with a constant. Just make it a Double to begin with!

Here's one other thing, and maybe you did it to fit everything on the screen.

Generally, G-code should be read from left-to-right to make analyzing the data flow easier.

The output of the select node goes from right to left. Does it hurt the code? No. It just doesn't look as good, and it makes it look like you're outputting something from the Set Motor VI.
__________________
Garnet Squadron
FRC 4901
Controls Mentor
@rnazaretian

Previous mentor and student from Team Fusion, FRC 364
Reply With Quote