View Single Post
  #2   Spotlight this post!  
Unread 08-12-2013, 21:05
Bryan Herbst's Avatar
Bryan Herbst Bryan Herbst is offline
Registered User
AKA: Bryan
FRC #2052 (KnightKrawler)
Team Role: Mentor
 
Join Date: Sep 2007
Rookie Year: 2007
Location: Minneapolis, Minnesota
Posts: 544
Bryan Herbst has a reputation beyond reputeBryan Herbst has a reputation beyond reputeBryan Herbst has a reputation beyond reputeBryan Herbst has a reputation beyond reputeBryan Herbst has a reputation beyond reputeBryan Herbst has a reputation beyond reputeBryan Herbst has a reputation beyond reputeBryan Herbst has a reputation beyond reputeBryan Herbst has a reputation beyond reputeBryan Herbst has a reputation beyond reputeBryan Herbst has a reputation beyond repute
Re: FRC Survival Guide for Android

It looks pretty good!

I'm an Android developer, so I'm probably going to be a bit nit picky. Here are my suggestions (using a Nexus 5):

First, do not ask the user to confirm closing the app when the back button is pressed. This is somewhat of an anti-pattern in Android. Yes, I know there's an option in the app's preferences, but there shouldn't be (or it should default to off). See the flowchart on the Confirming & Acknowledging page of the Android developer docs for some more guidance on this. In short, you should only confirm an action if it could cause the user to lose data or otherwise significantly inconvenience them.

Second, you have some odd margin/padding things going on. See my first attachment- the extra space outside of both the content and the tabs is a bit awkward. This disappears when I enable the navigation drawer. It also happens with the main ListView (attachment 2), but I can concede that could be a design decision. I personally expected the ListView to fill the width, but you could convince me otherwise.

Thirdly, the text in the "About KING TeC" dialog turns black when pressed (see third attachement). I think this usually occurs when android:autolink is set on a TextView, and can be circumvented by manually specifying a color. IMO, the dialog should also have a "close" button. Dialogs without any sort of action button can be confusing.

Finally, I suggest a different application icon for a few reasons. First, this icon doesn't really say anything about the app. Second, it will be a little strange if your team comes out with a second app, since the icon is a team logo.

Keep up the good work!
Attached Thumbnails
Click image for larger version

Name:	2013-12-09 01.40.24.png
Views:	34
Size:	482.5 KB
ID:	15517  Click image for larger version

Name:	2013-12-09 01.44.12.png
Views:	25
Size:	87.9 KB
ID:	15518  Click image for larger version

Name:	2013-12-09 01.42.25.png
Views:	39
Size:	282.2 KB
ID:	15519  
__________________
Team 2052- Knightkrawler
Mentor and volunteer

Last edited by Bryan Herbst : 08-12-2013 at 21:07.
Reply With Quote