View Single Post
  #2   Spotlight this post!  
Unread 24-01-2014, 22:44
Domenic Rodriguez's Avatar
Domenic Rodriguez Domenic Rodriguez is offline
Registered User
FRC #0316 (LuNaTeCs)
Team Role: College Student
 
Join Date: Sep 2010
Rookie Year: 2011
Location: Grove City, PA
Posts: 213
Domenic Rodriguez has a spectacular aura aboutDomenic Rodriguez has a spectacular aura aboutDomenic Rodriguez has a spectacular aura about
Re: Motor Programming

In the constructor for each of your commands, you should pass the instance variable from CommandBase instead of the Subsystem class name:

Code:
public LiftForks() {
    // Use requires() here to declare subsystem dependencies
    // eg. requires(chassis);
    requires(forkMotor);  // or whatever you named the instance variable
}
instead of
Code:
public LiftForks() {
    // Use requires() here to declare subsystem dependencies
    // eg. requires(chassis);
    requries(ForkMotor);
}
Another potential issue is that you don't appear to ever be stopping the motor. Even when the commands end, the motor will continue to spin (at least until the motor safety kicks in). One way to solve this issue would be to add a stop() method to your Subsystem, and then calling that method in each command's end() method.
__________________

LuNaTeCs - Learning Under Nurturing Adults Teaching Engineering Concepts and Skills - Small and Mighty!

FRC 316 LuNaTeCs - Student (2011-2014), Lead Programmer (2011-2014), Team Captain (2013-2014), Operator (2013), Drive Coach (2014), Mentor (2015-????)
'11 Philly Regional Finalists, '13 Chestnut Hill Finalists, '13 Lenape Champions, '13 Archimedes Division, '14 Chestnut Hill Champions, '14 Lenape Champions
FTC 7071 EngiNerds - Founding Advisor (2013-2014) | FRC 5420 Velocity - Founding Advisor (2015)
Grove City College Class of '18, Electrical/Computer Engineering (B.S.E.E)


Last edited by Domenic Rodriguez : 24-01-2014 at 22:45. Reason: Grammar
Reply With Quote