Code-wise that is fine.
Does the motor controller LED react to movement on the joystick?
Also, if you're using Jaguars: I know they have a feature where you can have it handle checking for limit switch stops. I haven't used Jags since 2011, but based on the guide (
http://content.vexrobotics.com/docs/...artedGuide.pdf) you should have two vertical jumpers on the far right pins.