Looks good,
I may be wrong, but It appears you have the red and green LED's the wrong way around.
When PWM White is high, RLY1 fires such that there is 12v at M+, turning the voltage across D5 and R3 to 0v, thus effectivly turning off green LED and leaving the red one on. This is contary to what I've observed on spikes and the truth table from the manual:
http://content.vexrobotics.com/docs/...uide-sep05.pdf
Are the component numbers in your schematic the same as those on the silk screen? Also what revision Spike do you have? I've got a REV D and it has a few extra resistors and diodes.
Aside from that, looks good
