Quote:
Originally Posted by lopsided98
I forked the project and starting working on fixing some of the bugs. The first major change was to create a .gitignore file and remove all the autogenerated code from the repository. I also upgraded all the plugins, tools and targetSdkVersion to the latest versions.
As far as the code itself, you made it sound like it was much more messy than it is. 
So far I have fixed: - Negative signs not shown in joystick editor
- Make joystick creation dialog scrollable
- Sensible defaults (I think*) for joystick creation
- Joystick vibration on long press (sort of)
- Misspellings
*Are the joystick/axis indices are 0 or 1 based?
Also, I should mention that the bug fixes have not been pushed to the repository yet, as I am still working on them. |
Buttons and axis' are 0+. Thanks for the work you have done, sounds great. One other thing you could do if you'd like is change the joysticks and buttons to extend AxisControl and ButtonControl, where AxisControl has .getAxisCount() and .getAxisArray() and ButtonControl has .getButtonCount() and .getButtonArray(). If the PacketFactory class' register method's were then changed to registerAxisControl() and registerButtonControl() it would be much easier to create new controls such as slider, throttles, etc. since they would just have to extend AxisControl or ButtonControl.
I was planning on changing this, but don't want to mess with it since I can't test it and might just break everything. I know you have other things to work on, I just thought I should share my plan.