Thread: Major WPILib PIDController bug
View Single Post
  #13   Spotlight this post!  
Unread 17-03-2016, 21:06
Oblarg Oblarg is offline
Registered User
AKA: Eli Barnett
FRC #0449 (The Blair Robot Project)
Team Role: Mentor
  
Join Date: Mar 2009
Rookie Year: 2008
Location: Philadelphia, PA
Posts: 1,050
Oblarg has a reputation beyond reputeOblarg has a reputation beyond reputeOblarg has a reputation beyond reputeOblarg has a reputation beyond reputeOblarg has a reputation beyond reputeOblarg has a reputation beyond reputeOblarg has a reputation beyond reputeOblarg has a reputation beyond reputeOblarg has a reputation beyond reputeOblarg has a reputation beyond reputeOblarg has a reputation beyond repute
Re: Major WPILib PIDController bug
Quote:
Originally Posted by dvanvoorst View Post
However, I'd be interested in seeing isAvgErrorValid() being changed a bit to not return true until your buffer is full. I've had issues with OnTarget being true because of one value in the buffer when it first started up, even though I asked for a 20 reading average.
Agreed, this would be a very nice change.

Quote:
Originally Posted by virtuald View Post
Missed it.

Also, appears that C++ has an identical error.

Python does not have this error. C# does however.
Well, I'm certainly glad we noticed this, then.
__________________
"Mmmmm, chain grease and aluminum shavings..."
"The breakfast of champions!"

Member, FRC Team 449: 2007-2010
Drive Mechanics Lead, FRC Team 449: 2009-2010
Alumnus/Technical Mentor, FRC Team 449: 2010-Present
Lead Technical Mentor, FRC Team 4464: 2012-2015
Technical Mentor, FRC Team 5830: 2015-2016