Quote:
Originally Posted by Greg McKaskle
I looked at your updated code, and still don't see anything that scary. Moving the code into subVIs helps readability, but won't affect performance.
So do you have CPU numbers? Do you have a log file? Do you have an elapsed time for TeleOp?
The only thing that looks like it may be excessive is the amount of stuff you have inside the 10ms periodic task. Doing NavX and CAN status and quite a few network tables may add a pretty hefty background load which would be present even during disabled mode. So if we see the logs, I can know roughly what that takes.
Greg McKaskle
|
This might be a ridiculous question to ask but would finding a way to move the majority of this stuff to a state machine be of any use when trying to make the code efficient? I feel like there's a few things that could probably go without the constant update that the Teleop.vi has. Do point out if I'm wrong in this case. Also Bradley, I've noticed that there are some unused values in your teleop code that can be attributing to the whole clutter issue that is evident in the project overall; I would assess whether or not you need those values anymore. Great job on your code however I've had fun puzzling your code out and have been able to glean a few concepts from this that are rather interesting and will keep a note on them for next robotics season. I'll continue to with my efforts and will point out anything that I see that might want to be addressed.