I just edited the program.
https://github.com/olidem123/PLS5618-2016
Quote:
|
1. We like to use constants in RobotMap.java, organized by kind of interface. We can then print this out and use it as instructions for wiring.
|
I changed those things a bit and it looks a lot better, still need to test it. Thx
Quote:
|
2. In AvancerHerse, consider using more descriptive variable names:
|
I just removed this part of the program because we found out it was useless.
Quote:
4. In BrasCommand, you didn't put this in braces:
Code:
} else
Robot.bras.controlBras(0);
|
Guess I forgot them
Quote:
|
Instead of having the command pair InBallon/OutBallon, which are very similar, I think it makes more sense to have a single command handle both, eg
|
I use 2 commands because I found it easier to set up 2 buttons to one command each.
Quote:
|
Not just student code - many company coding standards require this as well, including Java code written for/at Google.
|
I'll take a good look at that
PS: I sent this post to our mentors for tips for the future years. Thx for all your support!