View Single Post
  #5   Spotlight this post!  
Unread 14-01-2005, 12:11
Mr. Lim Mr. Lim is offline
Registered User
AKA: Mr. Lim
no team
Team Role: Leadership
 
Join Date: Jan 2004
Rookie Year: 1998
Location: Toronto, Ontario
Posts: 1,125
Mr. Lim has a reputation beyond reputeMr. Lim has a reputation beyond reputeMr. Lim has a reputation beyond reputeMr. Lim has a reputation beyond reputeMr. Lim has a reputation beyond reputeMr. Lim has a reputation beyond reputeMr. Lim has a reputation beyond reputeMr. Lim has a reputation beyond reputeMr. Lim has a reputation beyond reputeMr. Lim has a reputation beyond reputeMr. Lim has a reputation beyond repute
Re: CMUCam2 Camera Code - Are important parts commented out?

Quote:
Originally Posted by Mike Betts
Roger,

It makes sense that FIRST/IFI would comment out code so that it is safe for people to simply "run" on a robot without fully understanding function.
Although I agree with you, in this particular case it is a misrepresentation to publish and distribute a document like: "Start_Here-CMUcam2_fe.pdf" that gives absolutely no mention to having to uncomment code.

Quote:
I would suggest that you implement a piece at a time with appropriate debug printf statements to understand what each part does. Note that some code may require modification by you to be compatible with your system.

As an example, I would insure that the camera is giving good information to your controller before I attempted to let it guide the drive system of your robot.

Mike
We are receiving proper T-packets, with good x/y cam co-ordinates. FIRST/IFI already included a printf debug statement in this regard (from user_routines_DDT.c):
Code:
	// Put vision processing here, because we have a good frame!
	printf( "Got T packet %d %d %d %d servo: %d %d\r",cam.x,cam.y,cam.size,cam.conf,cam.pan_servo,cam.tilt_servo );
	if (cam.size > 0 && p1_sw_trig>0)	{			//Check to see if camera is tracking
		tracking = 1;								// if yes then set 'tracking' flag
		pan_position = cam.pan_servo;
	}
	else
		tracking = 0;								// if there is no track, clear the flag
	}
EUREKA!!!! THERE IT IS!!!! AND IT'S NOT COMMENTED OUT!

Thanks Mike! Your post led me to find the real non-commented out camera handler!!!

It appears the answer is NO, important parts of the camera code ARE NOT commented out. This SHOULD still work out of the box with little to no code modification

-SlimBoJones...

P.S. My question has been answered! Moderators may close this thread if they wish.

Last edited by Mr. Lim : 14-01-2005 at 12:15. Reason: Added thread closure request