View Single Post
  #3   Spotlight this post!  
Unread 25-01-2008, 20:42
psy_wombats's Avatar
psy_wombats psy_wombats is offline
Registered User
AKA: A. King
FRC #0467 (Duct Tape Bandits)
Team Role: Programmer
 
Join Date: Jan 2007
Rookie Year: 2007
Location: Shrewsbury MA
Posts: 95
psy_wombats has a spectacular aura aboutpsy_wombats has a spectacular aura aboutpsy_wombats has a spectacular aura about
Re: Newer issues....

That doesn't look too bad. Two main things I notice from a cursory glance:

-You're using the assignment operator ( = ) in your if statements. Use the double equals ( == ) if you want to test equivalency. And the eqivalency things are in the assignments. You just need to double the equals where you have one and halve it where you have two right now. (I know this error, that's the first C mistake I ever made)

-You don't need the extra else if. You could probably use just the else, as the if will always be true. Not a necesity, but just a style thing I noticed.

Are you having any specific problems, or just looking for a first review of the code?

Last edited by psy_wombats : 25-01-2008 at 20:45.