View Single Post
  #1   Spotlight this post!  
Unread 01-02-2008, 14:07
Tom Bottiglieri Tom Bottiglieri is offline
Registered User
FRC #0254 (The Cheesy Poofs)
Team Role: Engineer
 
Join Date: Jan 2004
Rookie Year: 2003
Location: San Francisco, CA
Posts: 3,187
Tom Bottiglieri has a reputation beyond reputeTom Bottiglieri has a reputation beyond reputeTom Bottiglieri has a reputation beyond reputeTom Bottiglieri has a reputation beyond reputeTom Bottiglieri has a reputation beyond reputeTom Bottiglieri has a reputation beyond reputeTom Bottiglieri has a reputation beyond reputeTom Bottiglieri has a reputation beyond reputeTom Bottiglieri has a reputation beyond reputeTom Bottiglieri has a reputation beyond reputeTom Bottiglieri has a reputation beyond repute
Re: Team 166 Has Open Sourced Its Code

A little constructive criticism... I see a lot of logic being implemented in conditional statements that does not need to be. For example:
Code:
if(pressure_sensor == 0) compressor = 1; 	
    else compressor = 0;
could be
Code:
compressor != pressure_sensor;
From what I see you can cut out a good chunk of code and boost your efficiency by doing some simple optimizations.