Thread: is it right ???
View Single Post
  #3   Spotlight this post!  
Unread 12-02-2008, 19:59
Alan Anderson's Avatar
Alan Anderson Alan Anderson is offline
Software Architect
FRC #0045 (TechnoKats)
Team Role: Mentor
 
Join Date: Feb 2004
Rookie Year: 2004
Location: Kokomo, Indiana
Posts: 9,113
Alan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond reputeAlan Anderson has a reputation beyond repute
Re: is it right ???

Quote:
Originally Posted by Lilor View Post
Code:
if (!IRswitch1)    //If the IR has been pressed
pwm01-255;
pwm03-255;         //Do whatever when switch is down
}
A few comments:

First, the IR sensor board signals are read as 0 (false) when not active, and as 1 (true) when detecting a signal. That's the opposite of how a switch to ground is typically sensed, so you need to remove the exclamation point.

Second, because of this behavior, a disconnected board will read as if all four signals are active simultaneously. It would be a good idea to put in a check to make sure only one signal is being detected, and ignore everything if multiple signals show up at the same time.

Third, I think you meant to use an equals sign instead of a minus sign. As you have written it, the compiler will accept such lines without complaint, but the code won't actually do anything.

Fourth, you don't have any open braces after your if statements. The compiler will not be happy about that, and will complain about what it thinks is an "extra" closing brace when it encounters one.

Finally, the maximum output for a pwm signal is actually 254, not 255. (I don't know where in the system it gets limited, but I know the dashboard will show 254 if you do attempt to set a pwm output to 255.)