View Single Post
  #10   Spotlight this post!  
Unread 13-05-2010, 08:33
JesseK's Avatar
JesseK JesseK is offline
Expert Flybot Crasher
FRC #1885 (ILITE)
Team Role: Mentor
 
Join Date: Mar 2007
Rookie Year: 2005
Location: Reston, VA
Posts: 3,637
JesseK has a reputation beyond reputeJesseK has a reputation beyond reputeJesseK has a reputation beyond reputeJesseK has a reputation beyond reputeJesseK has a reputation beyond reputeJesseK has a reputation beyond reputeJesseK has a reputation beyond reputeJesseK has a reputation beyond reputeJesseK has a reputation beyond reputeJesseK has a reputation beyond reputeJesseK has a reputation beyond repute
Re: Collaborations and Alliances

Quote:
Originally Posted by davidthefat View Post
Code:
if(isRunning){
}
use
Code:
if(isRunning == true)
{
}
At the end of the day, it's still 1 SLOC and 1 operation. This line isn't even a code smell. If such an example is a reason to not cooperate with another team then you seriously should intrinsically think about whether or not your team is capable of forgiving another team's nuances enough to cooperate to begin with (i.e., it's your problem and not the other team's...).

In the real world, if you make the mistake of bad 'style' other programmers will let you know. Yet upper management tends to not care because it really doesn't effect performance. So long as your company has some sort of code review process 'style' tends to work itself out over the long term, so it's not even a matter of increased development or maintenance for a set of code. Essentially, this is like arguing whether the '//' comments line for line are better than block /* */ comments for readability. The reality, it's the words within the contents that matter -- most of the time programmers want to know why something is necessary rather than:

(Java code)
Code:
//Initialize CORBA References
org.omg.ORB orb = initCorbaReferences();

//Initialize the display
mDisplay.init();
Food for thought.
__________________

Drive Coach, 1885 (2007-present)
CAD Library Updated 5/1/16 - 2016 Curie/Carver Industrial Design Winner
GitHub

Last edited by JesseK : 13-05-2010 at 08:37.
Reply With Quote