Quote:
Originally Posted by jhersh
I finally took the time to look into this issue. I found the source of the mysterious factor of 2 that was introduced ....
I've attached the final patch that went in for those who are curious.
-Joe
|
Thanks Joe, you done well.
A few questions/comments:
1) I see you took my suggestion for the x1,x2 and x4 averaging pulse count. Did you take a look to see if this really helped the rate noise increase with the x2 and x4 configs? I sort of have mixed feelings on this now. It should sure help if all the pulses are within a single reference frame, but would be less effective if averaging pulses which are part of different frames.
I still would like you to add a SetMovingAveragePulseCount(int max_count) procedure to allow user control of this.
2)Did you set the rate = zero at a same edge event rather than no report at all in your subcode? If not is this in your plans?
3)Did you try to implement the signed pipeline as I suggested so you don't have to reset the pipeline at zero crossings
http://www.chiefdelphi.com/forums/sh...5&postcount=85 ?