Can't get motors to spin correct way.

[Wzup4021]

We have successfully gotten our robot wheels (6 wheel tank drive, 2 motors on each side) to spin, however they are going the wrong way. We have tried inserting a negative in many places in our code, we have tried multiplying by -1 and nothing seems to work. With everything we tried, the wheels will still spin the wrong way (they will spin either way, but the joystick/spin is reversed). Here is that part of the code:

public void operatorControl() {
chassis.setSafetyEnabled(true);
while (isOperatorControl() && isEnabled()) {
Joystick1 = leftStick.getAxis(Joystick.AxisType.kY);
Joystick2 = rightStick.getAxis(Joystick.AxisType.kY);

Originally we had this, but changed it to the above:
Joystick1 = leftStick.getY();
Joystick2 = rightStick.getY();


//Left Side Motor Code, controlled by the left joystick(might need to switch direction)
if ((Joystick1 < 0.1)&&(Joystick1 > -0.1)) {
LeftMotors.set(0);
}

else {
LeftMotors.set (Joystick1);
}

//Right Side Motor Code, controlled by the right joystick(might need to switch direction)
if ((Joystick2 < 0.1)&&(Joystick2 > -0.1)) {
RightMotors.set(0);
}

else {
RightMotors.set(Joystick2);
}


}
}

[Racer26]

Personally: I've always found this to be the way to go.

value = leftStick.getRawAxis(1);

getAxis returns a object of type Axis. getRawAxis returns the value of the axis. Multiply by -1 accordingly.

note that the 1 in my code is the axis number. Usually, joysticks return the "x" axis as axis 0, the "y" axis as axis 1, and additional analog axes (thumb wheels, xbox controller triggers, etc) as 2, 3, 4, etc.

[Wzup4021]

So is "value" just a variable in this? And what does the (1) do at the end?

[jee7s]

I think most of us reading that need a bit more context, namely what types all of those variables are and where you tried to make your changes that didn't work.

Particularly:
1. What is the type of LeftMotors and RightMotors?
2. What is the type of Joystick1 and Joystick2?

If LeftMotors and RightMotors are a variant of a speed controller, and Joystick1 and Joystick2 are Joysticks, then code like this would work:

LeftMotors.Set(Joystick1.GetY());
RightMotors.Set(Joystick2.GetY());

And if you needed to reverse the right motors you would replace with this:
LeftMotors.Set(Joystick1.GetY());
RightMotors.Set(-1.0 * Joystick2.GetY());

But, like I said, a bit more context to your question would be helpful.

[Wzup4021]

I'm not sure if I get your question, but "Leftmotors" means 2 cim motors, controlled by Talons. Right, the opposite. I'm not sure what you mean by joystick type. Basically we have 2 joysticks, one for each side. We have the joysticks matched up to the right side, but getting them to go the right way is what we are having issues with.

[ArchosR4]

Have you tried looking for a generic drive function in your library. Such as tank or arcade drive? If you dont have these functions set one set of motors to a negative out put and leaving the other to a positive. Your function to remove the deadband of the controller looks good. however i would take it out until you get the motors to run in the right direction.

[Wzup4021]

We used the tank drive template. We have tried inserting negatives everywhere we can think of (one at a time ofc) and also tried multiplying by -1. They still spin the same way regardless. Also, why should we remove the deadpan code, any reason?

[jee7s]

Originally Posted by Wzup4021

We used the tank drive template. We have tried inserting negatives everywhere we can think of (one at a time ofc) and also tried multiplying by -1. They still spin the same way regardless. Also, why should we remove the deadpan code, any reason?

At this point, remove the deadband code to simplify your debugging.

Regarding the type, somewhere in your code you should have a block of declarations that look like this:

Joystick Joystick1;
Joystick Joystick2;
Jaguar LeftMotors;
Jaguar RightMotors;

...Or some such thing. Can you show us the declarations of those objects? Or, post your code so we can get a better picture.

[Wzup4021]

obotDrive chassis = new RobotDrive(1, 2);
private final Joystick leftStick = new Joystick(1);
private final Joystick rightStick = new Joystick(2);
Talon LeftMotors = new Talon(1);
Talon RightMotors = new Talon(2);
private double Joystick1;
private double Joystick2;

[Racer26]

Originally Posted by Wzup4021

obotDrive chassis = new RobotDrive(1, 2);
private final Joystick leftStick = new Joystick(1);
private final Joystick rightStick = new Joystick(2);
Talon LeftMotors = new Talon(1);
Talon RightMotors = new Talon(2);
private double Joystick1;
private double Joystick2;

Yes, so simply putting:

chassis.TankDrive(leftStick,rightStick);

in your OperatorControl() function ought to take care of it. If motors spin the wrong direction at that point, flip the wires at the speed controller output.

[jee7s]

Originally Posted by Wzup4021

obotDrive chassis = new RobotDrive(1, 2);
private final Joystick leftStick = new Joystick(1);
private final Joystick rightStick = new Joystick(2);
Talon LeftMotors = new Talon(1);
Talon RightMotors = new Talon(2);
private double Joystick1;
private double Joystick2;

Ah, now that looks like you are stepping on your own code. Does the RobotDrive class declare and instantiate the joysticks and talons? If it does, then you are trying to set values from two different places. That might be causing your complication.

From the other poster's comment, I think all you need is that first line where you instantiate a new RobotDrive.

[Racer26]

Originally Posted by jee7s

Ah, now that looks like you are stepping on your own code. Does the RobotDrive class declare and instantiate the joysticks and talons? If it does, then you are trying to set values from two different places. That might be causing your complication.

From the other poster's comment, I think all you need is that first line where you instantiate a new RobotDrive.

First 3. RobotDrive instantiates the motors on its own but does not instantiate the Joysticks. (though stop to think of it, I'm not sure what it instantiates them as... Talon, Jaguar, and Victor all extend the SpeedController class...)

EDIT: Looking at the WPIlib reference, they're instantiated as Victors. you can also pass SpeedController objects to the RobotDrive constructor if you want something other than Victors.

In this case, they could go:

Talon leftDrive = new Talon(1);
Talon rightDrive = new Talon(2);
RobotDrive chassis = new RobotDrive(leftDrive, rightDrive);

[jee7s]

Originally Posted by Racer26

First 3. RobotDrive instantiates the motors on its own but does not instantiate the Joysticks. (though stop to think of it, I'm not sure what it instantiates them as... Talon, Jaguar, and Victor all extend the MotorController class...)

For total clarity, that means you need to declare these:
RobotDrive chassis = new RobotDrive(1, 2);
private final Joystick leftStick = new Joystick(1);
private final Joystick rightStick = new Joystick(2);

And then call this:
chassis.TankDrive(leftStick, rightStick);

If you then have a side spinning in the wrong direction, swap the MOTOR wiring on the Talon OUTPUT. (Don't swap the input wiring, as you'll fry the talon.)

[Wzup4021]

Okay, we discussed reversing the output wires on the Talons, but our team members are worried that in inspection they will tell us we can't have red to negative and black to positive. Has anybody had to reverse hot/cold wires and gotten in trouble for it, or were inspectors okay with it?

[jee7s]

Originally Posted by Wzup4021

Okay, we discussed reversing the output wires on the Talons, but our team members are worried that in inspection they will tell us we can't have red to negative and black to positive. Has anybody had to reverse hot/cold wires and gotten in trouble for it, or were inspectors okay with it?

Speaking as an inspector, we don't mind which color wire goes to which output terminal of the talon or any other speed controller to a motor. Strictly speaking, those don't have a polarity since the talon can reverse it based on the PWM signal it receives. It's only the input side we worry about, and as I said before, if you hook that up backwards you destroy the talon.

MANY teams have the speed controller output polarities flipped on one side of the robot.