Programming Help!

[davidthefat]

Memory leak? You have to be really careful when using malloc. That is if you don't know what you are doing, just use "new". You never freed your allocated data.

Add:
free(Elevator_heights);
after that for loop

edit: my analogy I like to use is like feeding a kid a whole bunch of food and not letting him poop afterwards. So that stays inside of him until you let him poop or he dies (the program exits).

[jwakeman]

you have to be just as careful whether your using new or malloc. maybe even a little more careful when using new because then you have to choose correctly between delete and delete[]

[davidthefat]

Originally Posted by jwakeman

you have to be just as careful whether your using new or malloc. maybe even a little more careful when using new because then you have to choose correctly between delete and delete[]

That is what programming in Java 24/7 does to your mind. I almost forgot about that.

[MattD]

Originally Posted by davidthefat

Add:
free(Elevator_heights);
after that for loop

I'm not sure why this would be freed at after that for loop. It looks like there are other functions that want to access that array later on. It should be freed somewhere else (perhaps a destructor), but I don't think that this is the source of the problem. It appears it's only called at most twice during the program's run before it crashes.

As mentioned already, that Elevator_Mechanism structure is very strange looking. It's difficult to follow, so I can't say for sure whether or not that part would work.

Spoiler for incorrect information:

Here's what I noticed at a quick glance in the constructor's initialization list:

Carriage_motor(new Victor(4)),
Elevator_motor(new Victor(3)),

These are defined earlier as:

Victor *Elevator_motor;
Victor *Carriage_motor;

I believe you should have instead:

Carriage_motor(3),
Elevator_motor(4),

This is because the constructor for Victor expects an int with the value of a PWM port, and instead you're passing a pointer to a Victor. Since there are checks to make sure a valid PWM channel number is provided, I'd expect an IndexOutOfRange ("Allocating channel or module that is out of range") fatal error to be thrown by WPILib.

This is a situation where it would be useful to post the console output. The debugger would also be a valuable tool to use.

[CodeMonkeyMatt]

Good catch on the constructors. Actually though, I think the whole lines for the Carriage motor and elevator motor before the "{" braces should be taken out. Since those are declared as pointers, you use the "name = new ClassName(args);" format in the actual constructor, which you were doing, but then commented out.

If you declared the objects as actual objects instead of as pointers (i.e. Victor Elevator_motor; Victor Arm_motor; instead of Victor *Elevator_motor; Victor *Arm_motor; ) then you would use the format described by MattD.

As always, I'm only a fallible student, so someone feel free to disprove me.

[MattD]

Originally Posted by CodeMonkeyMatt

Since those are declared as pointers, you use the "name = new ClassName(args);" format in the actual constructor, which you were doing, but then commented out.

If you declared the objects as actual objects instead of as pointers (i.e. Victor Elevator_motor; Victor Arm_motor; instead of Victor *Elevator_motor; Victor *Arm_motor; ) then you would use the format described by MattD.

That's right, and I was not even thinking about that. Good catch. My previous post was incorrect.