Go to Post .. if everybody else is buying all the thingamabobs so they can practice shoving balls into the whatsit. Maybe what you really want is to buy thingys so you can build a practice whojidingle. Being the only whojidingle robot can be a real advantage come alliance picking time ... - ChrisH [more]
Home
Go Back   Chief Delphi > Technical > Programming > NI LabVIEW
CD-Media   CD-Spy  
portal register members calendar search Today's Posts Mark Forums Read FAQ rules

 
 
 
Thread Tools Rate Thread Display Modes
Prev Previous Post   Next Post Next
  #2   Spotlight this post!  
Unread 04-04-2011, 18:36
WizenedEE's Avatar
WizenedEE WizenedEE is offline
Registered User
AKA: Adam
FRC #3238 (Cyborg Ferrets)
Team Role: Leadership
 
Join Date: Jan 2011
Rookie Year: 2010
Location: Anacortes, WA
Posts: 395
WizenedEE is a name known to allWizenedEE is a name known to allWizenedEE is a name known to allWizenedEE is a name known to allWizenedEE is a name known to allWizenedEE is a name known to all
Re: Would Someone mind looking over my autonomous.

  • Neither the top triplet nor the bottom triplet of while loops has a delay in them
  • You may want to change those waits to the other kind of wait (wait until next multiple), becuase that's more accurate.
  • The top triplet of loops will all execute at the same time; put a wire between them or use a sequence structure
  • You may want to combine all of the stages of the top 9 loops into one, so they stay synchronized.
  • When you stop on the last loop, you probably want to just put a false constant for the while loop so that it never ends; that way, the motors kept getting written to and don't give errors
  • In the bottom loop, why do you write to a global and then immediately read it again instead of just using a wire?
  • Check to see if there's a better way to calibrate the encoders than to just add a constant, but there may not be.
  • To make it more readable, you may want to replace some of those one-input-one-output case structures with selects
  • Instead of putting a not in the wire and then having a case structure, you could just swich around the cases. Again, not that important.
  • Comments might be nice, but again not too important
  • Your code is extremely clean, I'm impressed... I just punch the built in clean up button and live with it

That's everything I could find. Good luck with it though!
Reply With Quote
 


Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump


All times are GMT -5. The time now is 20:54.

The Chief Delphi Forums are sponsored by Innovation First International, Inc.


Powered by vBulletin® Version 3.6.4
Copyright ©2000 - 2017, Jelsoft Enterprises Ltd.
Copyright © Chief Delphi