Go to Post Mentoring is HARD. - Akash Rastogi [more]
Home
Go Back   Chief Delphi > Technical > Programming > Java
CD-Media   CD-Spy  
portal register members calendar search Today's Posts Mark Forums Read FAQ rules

 
 
 
Thread Tools Rate Thread Display Modes
Prev Previous Post   Next Post Next
  #4   Spotlight this post!  
Unread 20-12-2011, 08:36
gixxy's Avatar
gixxy gixxy is offline
Programming and Arduino Mentor
AKA: Gustave Michel III
FRC #3946 (Tiger Robotics)
Team Role: Mentor
 
Join Date: Nov 2011
Rookie Year: 2012
Location: Ruston, LA
Posts: 207
gixxy is on a distinguished road
Re: Would someone review my code?

Explation my use of a ControlMap interface: Its for if you may have more than one controls setup. Since right now i only have one ControlBoard class it is fairly useless, but if say I wanted to make it so that I could switch between Arcade and Tank Drive, It would come in handy. I can just re-init the same ControlMap interface in Controller using the other ControlBoard's object.


did i really use protected on the singleton classes constructors...... (I wrote it, and the getInstance() method once then copy and pasted it, changing the class names). Yep, derp on my part.

As with packages, I normally would have used them, but this was simple enough that it didn't matter.

With masterControl() and Controller.... I changed it when I realized I had called the class TheUser and the Method masterControlProgram().... I felt I had let my geek get away from me too much.....

also, I did take a look at the command based template, and personally haven't taken to it yet, I prefer it being open ended. I'm sure once I actually use it I will feel differently, but for now I wrote it with the template I felt I liked best.

And in any case: Thanks, some very good information.
Reply With Quote
 


Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump


All times are GMT -5. The time now is 11:17.

The Chief Delphi Forums are sponsored by Innovation First International, Inc.


Powered by vBulletin® Version 3.6.4
Copyright ©2000 - 2017, Jelsoft Enterprises Ltd.
Copyright © Chief Delphi