Check My Autonomous Code

[RyanN]

I didn't really edit any of your code. You had a floating number and boolean that I deleted, and I move a few elements around to better document it.

[jhellr13]

Originally Posted by RyanN

I didn't really edit any of your code. You had a floating number and boolean that I deleted, and I move a few elements around to better document it.

You think the bottom code will work now? How about the virtual digital inputs?

[RyanN]

Originally Posted by jhellr13

You think the bottom code will work now? How about the virtual digital inputs?

No, the bottom code won't work. Check out the comments I left in the code.

[jhellr13]

Originally Posted by RyanN

No, the bottom code won't work. Check out the comments I left in the code.

Just fixed some of the things you commented. I appreciate the comments you had with my logic on somethings, but I kept them the way they were because I am confident that logic works. I added timers and a while loop at the end, though I'm not too sure on that while loop. I didn't change much in the part with the arm because I couldn't quite understand your comment.

To give you more insight of how the arm works, I'll describe it to the best of my ability. It starts straight up, then rotates down to I guess to be something like a 115 degree angle or whatever needed to tilt the bridge on our robot. At that lowest point, there is a limit switch to make the output 0. I am trying to make this autonomous work where when it moves to that sequence, the arm will rotate down at 1, then hit 0 when limit switch is hit. I'm definite the logic is correct as it is also used in my teleop.

[RyanN]

Originally Posted by jhellr13

Just fixed some of the things you commented. I appreciate the comments you had with my logic on somethings, but I kept them the way they were because I am confident that logic works. I added timers and a while loop at the end, though I'm not too sure on that while loop. I didn't change much in the part with the arm because I couldn't quite understand your comment.

To give you more insight of how the arm works, I'll describe it to the best of my ability. It starts straight up, then rotates down to I guess to be something like a 115 degree angle or whatever needed to tilt the bridge on our robot. At that lowest point, there is a limit switch to make the output 0. I am trying to make this autonomous work where when it moves to that sequence, the arm will rotate down at 1, then hit 0 when limit switch is hit. I'm definite the logic is correct as it is also used in my teleop.

Can you post your new code so I can take a look? My comment about the logic is that you have some stuff in there that doesn't do anything, and then some of it that doesn't do anything will cause your motor to keep running indefinitely.

Let me step you through your own logic.

We're looking at this code right here:


Let's clean it up to view everything a little better:


Now let's minimize the code, removing code that does nothing.
Step 1:


Step 2:


Step 3:


Please let me know if you do or do not understand this. The reason it all cancels out to a False is because you're using an AND gate, meaning both input X AND input Y must be True in order for the Output to be True.

[jhellr13]

Originally Posted by RyanN

Can you post your new code so I can take a look? My comment about the logic is that you have some stuff in there that doesn't do anything, and then some of it that doesn't do anything will cause your motor to keep running indefinitely.

Let me step you through your own logic.

We're looking at this code right here:
Attachment 12440

Let's clean it up to view everything a little better:
Attachment 12441

Now let's minimize the code, removing code that does nothing.
Step 1:
Attachment 12442

Step 2:
Attachment 12443

Step 3:
Attachment 12444

Please let me know if you do or do not understand this. The reason it all cancels out to a False is because you're using an AND gate, meaning both input X AND input Y must be True in order for the Output to be True.

Alright. I'll change that stuff later in the day. Sort of in a rush right now, but I attached my new code from last night.

[RyanN]

Originally Posted by jhellr13

Alright. I'll change that stuff later in the day. Sort of in a rush right now, but I attached my new code from last night.

Keep me informed. I'm wanting to get it working for you.

[jhellr13]

Originally Posted by RyanN

Keep me informed. I'm wanting to get it working for you.

I just looked over the code again. I left the logic you were talking about the same as I feel safer keeping it the way I've always done limit switches since I know it works. I'm not doubting your suggestions, I would just like to keep it the way it is.

The new code is in my previous response in the zip attachment.

[RyanN]

Well, I'm going to tell you right now, it's will not work. I cannot explain it any further. Maybe someone else can look at your code and help you. I've done all I can do.

[RufflesRidge]

Originally Posted by RyanN

Well, I'm going to tell you right now, it's will not work. I cannot explain it any further. Maybe someone else can look at your code and help you. I've done all I can do.

Ryan is correct.

I highly recommend looking through Ryan's images above, step by step to see why your logic doesn't work the way you want it to (in addition to the fact that the code for the bottom mode isn't in a loop).

[jhellr13]

Originally Posted by RufflesRidge

Ryan is correct.

I highly recommend looking through Ryan's images above, step by step to see why your logic doesn't work the way you want it to (in addition to the fact that the code for the bottom mode isn't in a loop).

I'm gonna say it again. The logic I have in there for my limit switch for my bridge is 100% correct. It will work exactly as I need it to work. I've used that code before in teleop and it has worked. I have received this bit of code straight from http://team358.org/files/programming...2009-/LabVIEW/

Look for limit switch example. It works.

All I'm trying to do is get the robot to move the distance to the bridge using the encoders. Stop when the distance has been met, then lower the bridge arm down until the limit switch is hit.
I'm a second year programmer who has never had experience with autonomous. Last year I never even got to it as I started programming in week 4(Conversation for a different thread). I will easily admit I'm not too confident in writing the bottom code, and that is why I came here.

All I'm asking for is some help. My competition begins tomorrow, and I would love if I could get this to work.
Come on and help me out

[RufflesRidge]

Originally Posted by jhellr13

I'm gonna say it again. The logic I have in there for my limit switch for my bridge is 100% correct. It will work exactly as I need it to work. I've used that code before in teleop and it has worked. I have received this bit of code straight from http://team358.org/files/programming...2009-/LabVIEW/

Look for limit switch example. It works.

The limit switch example on that page works great; however, it does not match your code.

I highly recommend you be ready to disable the robot when testing that code to avoid breaking the arm and that you seek out an experienced LabVIEW team and/or the CSA at your event to help you out.