CodeProblem

[Cyan]

Originally Posted by legts

I think I know what your problem is. If, and if being the key word, button1 works, then my theory is correct. When declaring buttons, you need to have then declared exactly as button1 is declared. Namely, having "Button" before the button name. Hope I helped!

I don't believe this is the problem. Notice there are commas instead of semicolons at the end of each line; this should be the correct syntax.


As for AnnaliseDonavan, could you be more specific in your question? Also, which IDE do you use? Your code is relatively messy, so if you could show me one instance where your code does not work, you could troubleshoot through that pathway and follow example with the rest of the buttons.

[legts]

Originally Posted by Cyan

I don't believe this is the problem. Notice there are commas instead of semicolons at the end of each line; this should be the correct syntax.

I did not notice that before, thanks for pointing that out!

[AnnaliseDonavan]

As for the needing of semi colons for this set up when I place semi colons it produces an error and when I looked up the correct way to do the button control this is what I found.

And I apologist I am new to coding but no one on my team knows how to code so we are lost. For the one instance currently all I have in the implementing stage is the buttons so that is all the is and it dose not work.

[Cyan]

Try moving this code:

Button button1 = new JoystickButton(joystick, 1),
button2 = new JoystickButton(joystick, 2),
button3 = new JoystickButton(joystick, 3),
button4 = new JoystickButton(joystick, 4),
button5 = new JoystickButton(joystick, 5),
button6 = new JoystickButton(joystick, 6),
button7 = new JoystickButton(joystick, 7),
button8 = new JoystickButton(joystick, 8),
button9 = new JoystickButton(joystick, 9),
button10 = new JoystickButton(joystick, 10),
button11 = new JoystickButton(joystick , 11);

from Robot.teleopPeriodic() to Robot.robotInit(), and see if that leads to anything.

[om_nom_nom]

This may not solve much, but I suggest moving your button code into teleopInit(), otherwise you are creating buttons in a loop during teleop.

Also, have you tested your commands without the buttons? The issue may be that your commands are not working, not the buttons. To do this in Java, you can add

SmartDashboard.putData(new Command());

into your robotInit(). Then open up SmartDashboard from the driver station or a double-clicking on the program. You should see a button on the Dashboard after you compile that code. Click it to run, and click it again to cancel.

[GeeTwo]

Originally Posted by legts

I did not notice that before, thanks for pointing that out!

This is one of the important reasons to follow programming style conventions - that is, make your code look like programmers expect. In this case, the usual convention for objects is that the commas are only used if they are not being set. It's also common to keep columns aligned as you go down parallel code; this is why code is traditionally displayed in a fixed-width font. The usual style conventions would look like:

Button button1  = new JoystickButton(joystick,  1);
Button button2  = new JoystickButton(joystick,  2);
Button button3  = new JoystickButton(joystick,  3);
Button button4  = new JoystickButton(joystick,  4);
Button button5  = new JoystickButton(joystick,  5);
Button button6  = new JoystickButton(joystick,  6);
Button button7  = new JoystickButton(joystick,  7);
Button button8  = new JoystickButton(joystick,  8);
Button button9  = new JoystickButton(joystick,  9);
Button button10 = new JoystickButton(joystick, 10);
Button button11 = new JoystickButton(joystick, 11);

Following programming style conventions is nearly as important as following wiring color code conventions, and for exactly the same reason -- so that the guy (or gal) who comes behind you can easily figure out what you did. So far, it's not the law, or even in the FRC rules, but maybe it should be. Or maybe not -- do we really want code inspectors?