Major WPILib PIDController bug

[Oblarg]

Originally Posted by virtuald

I agree, that's a bug there. Different from what Oblarg was saying (unless they meant setSetpoint instead of enable).

As I clarified above, I did indeed mean that.

[virtuald]

Originally Posted by Oblarg

As I clarified above, I did indeed mean that.

Missed it.

Also, appears that C++ has an identical error.

Python does not have this error. C# does however.

[Oblarg]

Originally Posted by dvanvoorst

However, I'd be interested in seeing isAvgErrorValid() being changed a bit to not return true until your buffer is full. I've had issues with OnTarget being true because of one value in the buffer when it first started up, even though I asked for a 20 reading average.

Agreed, this would be a very nice change.

Originally Posted by virtuald

Missed it.

Also, appears that C++ has an identical error.

Python does not have this error. C# does however.

Well, I'm certainly glad we noticed this, then.

[Thad House]

Originally Posted by virtuald

Missed it.

Also, appears that C++ has an identical error.

Python does not have this error. C# does however.

Ah yes it does. I'll fix that in the C# code and hopefully we can get a push up to wpilib

[virtuald]

Pushed to gerrit here: https://usfirst.collab.net/gerrit/1372