Code Review: Semi-Novice

[Ben Wolsieffer]

Originally Posted by Lireal

The major issue I see with your code is that you are using the sybsystems and RobotMap completely wrong. Your RobotMap should only really include numbers. All of your motor controllers, sensors, etc. should be a in your subsystems. Read through these examples and you will see how to do it: https://wpilib.screenstepslive.com/s.../13809/c/88893

RobotMap does not necessarily need to only have numbers. In fact, RobotBuilder puts all the motor controller definitions in RobotMap, and then includes references to them in each subsystem. I don't necessarily think this is the best way to do it, but I would definitely say that it is not "wrong" to put things other than numbers in RobotMap.