Rate my Talon SRX breakout (EagleCAD)

[asid61]

Originally Posted by Maxwell777

The schematic should be wired such that the LED is always fed from the 3.3v rail, but the transistor base is fed by either 5v or 3v from the encoder. Unless that's not how electronics works, which is highly likely considering my background in electrical engineering consists of connecting red to red/black to black and V=I*R.

Oh nevermind, you're correct. I thought it was on a 5v/3.3v selector, but what you have is fine then.
For your forward and reverse limit, you should have to pads to connect the switches to, both GND and signal. That way the user doesn't need to muck about with wires going to odd places or anything.