Could someone look this over?

If Teflon-coated pans have a no-stick surface, then how to they get the Teflon to stick to the pans? - dlavery [more]

		Chief Delphi > Technical > Programming
Could someone look this over?

Thread Tools

Rate Thread

Display Modes

#11

08-02-2004, 12:19

Joe Ross

Registered User

FRC #0330 (Beachbots)

Team Role: Engineer

Join Date: Jun 2001

Rookie Year: 1997

Location: Los Angeles, CA

Posts: 8,571

Re: Could someone look this over?

Code:

     	if(currentPWM >= goalPWM + sensitivity)
     		return currentPWM - sensitivity;
     	if(currentPWM <= goalPWM - sensitivity)
     		return currentPWM + sensitivity;

Since everything is an unsigned char, then this code is a problem.
If goalPWM is 254 and sensitivity is 10 and CurrentPWM is 127, the result of (goalPWM + sensitivity) is 8 and so CurrentPWM is greater then 8 and you return 117 not 137 like you hope.

« Previous Thread | Portal | Next Thread »

Thread Tools
Show Printable Version Email this Page
Display Modes	Rate This Thread
Switch to Linear Mode Switch to Hybrid Mode Threaded Mode	Rate This Thread:

Posting Rules
You may not post new threads You may not post replies You may not post attachments You may not edit your posts vB code is On Smilies are On [IMG] code is On HTML code is Off

Forum Jump

All times are GMT -5. The time now is 22:13.

The Chief Delphi Forums are sponsored by Innovation First International, Inc.