Odd counter problems

[rbayer]

A few things I saw after glancing at it:

if (armcounter = 15) //will raise arm.
   pwm06=0;
else 
   armcounter++;
   pwm06=255;

sould be

if (armcounter == 15) //will raise arm.
   pwm06=0;
else {
   armcounter++;
   pwm06=255; 
}

It is VERY rare that you'll actually want to use a single = in an if, so watch out for that, and also be careful with your curly braces.

That said, I believe the code in its original form should have printf'd 15 over and over and over. Was it doing that, or just not printing anything?

[Ryan M.]

Originally Posted by rbayer

A few things I saw after glancing at it:

if (armcounter = 15) //will raise arm.
   pwm06=0;
else 
   armcounter++;
   pwm06=255;

sould be

if (armcounter == 15) //will raise arm.
   pwm06=0;
else {
   armcounter++;
   pwm06=255; 
}

It is VERY rare that you'll actually want to use a single = in an if, so watch out for that, and also be careful with your curly braces.

That said, I believe the code in its original form should have printf'd 15 over and over and over. Was it doing that, or just not printing anything?

Missing a = is an easy thing to do. It's one of those powerful, useful things that C/C++ lets you do, but isn't what you want most of the time.

[Catastrophy]

Well the = was something i accidently did when moving it i had it in the code i was using. and btw its just not printing anything.

[Ryan M.]

Originally Posted by Catastrophy

Well the = was something i accidently did when moving it i had it in the code i was using. and btw its just not printing anything.

So, the "test" prints, but the other thing doesn't?

[deltacoder1020]

Originally Posted by rbayer

A few things I saw after glancing at it:

if (armcounter = 15) //will raise arm.
   pwm06=0;
else 
   armcounter++;
   pwm06=255;

sould be

if (armcounter == 15) //will raise arm.
   pwm06=0;
else {
   armcounter++;
   pwm06=255; 
}

It is VERY rare that you'll actually want to use a single = in an if, so watch out for that, and also be careful with your curly braces.

That said, I believe the code in its original form should have printf'd 15 over and over and over. Was it doing that, or just not printing anything?

remember that you need to add the curly braces, not just change the equals sign to a double-equals. w/o the braces, the code is equivalent to this:

if (armcounter == 15) //will raise arm.
   pwm06=0;
else {
   armcounter++; 
}

pwm06=255;

note how pwm06 will always end up as 255, no matter what the value is.

you said that the "motors weren't stopping" - of course they aren't: 0 is full reverse, 255 is full forward. if you want a motor to stop, set the PWM to 127.

[Catastrophy]

Well i got it working i was messign with the code when i posted it so i accidently left stuff out. Thanks Tex helped a lot.