Go to Post I've found that housework is more fun with power tools. - RogerR [more]
Home
Go Back   Chief Delphi > Technical > Programming
CD-Media   CD-Spy  
portal register members calendar search Today's Posts Mark Forums Read FAQ rules

 
 
 
Thread Tools Rate Thread Display Modes
Prev Previous Post   Next Post Next
  #3   Spotlight this post!  
Unread 25-01-2008, 20:42
psy_wombats's Avatar
psy_wombats psy_wombats is offline
Registered User
AKA: A. King
FRC #0467 (Duct Tape Bandits)
Team Role: Programmer
 
Join Date: Jan 2007
Rookie Year: 2007
Location: Shrewsbury MA
Posts: 95
psy_wombats has a spectacular aura aboutpsy_wombats has a spectacular aura aboutpsy_wombats has a spectacular aura about
Re: Newer issues....

That doesn't look too bad. Two main things I notice from a cursory glance:

-You're using the assignment operator ( = ) in your if statements. Use the double equals ( == ) if you want to test equivalency. And the eqivalency things are in the assignments. You just need to double the equals where you have one and halve it where you have two right now. (I know this error, that's the first C mistake I ever made)

-You don't need the extra else if. You could probably use just the else, as the if will always be true. Not a necesity, but just a style thing I noticed.

Are you having any specific problems, or just looking for a first review of the code?

Last edited by psy_wombats : 25-01-2008 at 20:45.
 


Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
What Would You Say To The Newer Members Of CD - 2nd Edition JaneYoung General Forum 59 Yesterday 09:50
What would you say to newer members of the CD community? Ken Leung General Forum 25 30-01-2017 23:27
MpLab issues! AdmiralAllen Programming 3 15-01-2007 22:47
Weight Issues? team1852 Technical Discussion 9 12-01-2007 12:21
A newer, better geek test! evulish Chit-Chat 28 13-03-2004 15:47


All times are GMT -5. The time now is 19:08.

The Chief Delphi Forums are sponsored by Innovation First International, Inc.


Powered by vBulletin® Version 3.6.4
Copyright ©2000 - 2017, Jelsoft Enterprises Ltd.
Copyright © Chief Delphi