Go to Post It is easy to be righteous on Chief Delphi, and harder to implement in life. - DonRotolo [more]
Home
Go Back   Chief Delphi > Technical > Programming > C/C++
CD-Media   CD-Spy  
portal register members calendar search Today's Posts Mark Forums Read FAQ rules

 
Reply
Thread Tools Rate Thread Display Modes
  #1   Spotlight this post!  
Unread 08-02-2013, 11:46
kenfox kenfox is offline
Registered User
FRC #3322 (Eagle Imperium)
Team Role: Mentor
 
Join Date: Jan 2013
Rookie Year: 2013
Location: Ann Arbor, MI
Posts: 51
kenfox is a glorious beacon of lightkenfox is a glorious beacon of lightkenfox is a glorious beacon of lightkenfox is a glorious beacon of lightkenfox is a glorious beacon of light
Please don't reformat WPILib code during build season

I'm not sure who is working on WPILib, but it would be very nice if the mid-season releases didn't change source code formatting. I've been trying to keep up with bugs and fixes, but the cosmetic changes make the fixes harder to find.

Thank you for the source code releases by the way. It's incredibly valuable to be able to see how WPILib works rather than it being a black box.
Reply With Quote
  #2   Spotlight this post!  
Unread 08-02-2013, 12:15
virtuald's Avatar
virtuald virtuald is offline
RobotPy Guy
AKA: Dustin Spicuzza
FRC #1418 (), FRC #1973, FRC #4796, FRC #6367 ()
Team Role: Mentor
 
Join Date: Dec 2008
Rookie Year: 2003
Location: Boston, MA
Posts: 1,039
virtuald has a brilliant futurevirtuald has a brilliant futurevirtuald has a brilliant futurevirtuald has a brilliant futurevirtuald has a brilliant futurevirtuald has a brilliant futurevirtuald has a brilliant futurevirtuald has a brilliant futurevirtuald has a brilliant futurevirtuald has a brilliant futurevirtuald has a brilliant future
Re: Please don't reformat WPILib code during build season

Quote:
Originally Posted by kenfox View Post
I'm not sure who is working on WPILib, but it would be very nice if the mid-season releases didn't change source code formatting. I've been trying to keep up with bugs and fixes, but the cosmetic changes make the fixes harder to find.
I'm confused as to why you're keeping up with bugs and fixes? I mean it's great to be aware of them... but if you just don't use the previous version and install the latest binary from them, you're set to go...
__________________
Maintainer of RobotPy - Python for FRC
Creator of pyfrc (Robot Simulator + utilities for Python) and pynetworktables/pynetworktables2js (NetworkTables for Python & Javascript)

2017 Season: Teams #1973, #4796, #6369
Team #1418 (remote mentor): Newton Quarterfinalists, 2016 Chesapeake District Champion, 2x Innovation in Control award, 2x district event winner
Team #1418: 2015 DC Regional Innovation In Control Award, #2 seed; 2014 VA Industrial Design Award; 2014 Finalists in DC & VA
Team #2423: 2012 & 2013 Boston Regional Innovation in Control Award


Resources: FIRSTWiki (relaunched!) | My Software Stuff
Reply With Quote
  #3   Spotlight this post!  
Unread 08-02-2013, 13:54
kenfox kenfox is offline
Registered User
FRC #3322 (Eagle Imperium)
Team Role: Mentor
 
Join Date: Jan 2013
Rookie Year: 2013
Location: Ann Arbor, MI
Posts: 51
kenfox is a glorious beacon of lightkenfox is a glorious beacon of lightkenfox is a glorious beacon of lightkenfox is a glorious beacon of lightkenfox is a glorious beacon of light
Re: Please don't reformat WPILib code during build season

Quote:
Originally Posted by virtuald View Post
but if you just don't use the previous version and install the latest binary from them, you're set to go...
If we know what changed we can predict how our robot is affected. We can also review previously discarded approaches or learn something new.

On a more personal level, I'd like to be a part of the community. This is an incredible Open Source project with active and inspired development. In order for me to be effective, it's my responsibility to understand the code. I'm asking for a professional courtesy to help make that job easier.

You can see the changes in the latest WPILib here: https://github.com/FRC3322/WPILib/co...688e34f4b13ee1

The green lines are additions; the red lines deletions.
Reply With Quote
  #4   Spotlight this post!  
Unread 08-02-2013, 14:20
jwakeman jwakeman is offline
Registered User
FRC #0063 (Red Barons)
Team Role: Mentor
 
Join Date: Jan 2011
Rookie Year: 2010
Location: 16510
Posts: 182
jwakeman is just really nicejwakeman is just really nicejwakeman is just really nicejwakeman is just really nicejwakeman is just really nice
Re: Please don't reformat WPILib code during build season

After looking at your diff I see that you are just making the point that if (for example) a curly brace is moved from right after the method arguments to the next line it shows up as a difference which makes it more difficult to determine what functionaly changed in the code.

Not sure if you are aware but you can track (and submit) bugs and their fixes on the FIRST Forge site.

http://firstforge.wpi.edu/sf/tracker....wpilib_c_bugs
Reply With Quote
Reply


Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump


All times are GMT -5. The time now is 02:54.

The Chief Delphi Forums are sponsored by Innovation First International, Inc.


Powered by vBulletin® Version 3.6.4
Copyright ©2000 - 2017, Jelsoft Enterprises Ltd.
Copyright © Chief Delphi