Position and velocity PIDControllers using same encoder

[Oblarg]

Is there any supported way to do this in wpilib? It seems you have to set an encoder to be either kRate or kPosition - what if you want it to be one for one controller, and another for a different one? I suppose you could write a wrapper class that implements PIDSource and contains the encoder, but that seems ugly.

[nickbrickmaster]

Originally Posted by Oblarg

I suppose you could write a wrapper class that implements PIDSource and contains the encoder, but that seems ugly.

Looking at the code, I think this is your only option. If I had a dime for every time I had to implement an ugly solution, I'd have like, three dollars.

Alternately, use Python, and pass in the function you want as the PIDSource.

[Ether]

Are you permitted to wire the encoder to two separate pairs of inputs... one to decode rate and one to decode position?

[Oblarg]

Originally Posted by Ether

Are you permitted to wire the encoder to two separate pairs of inputs... one to decode rate and one to decode position?

Can't see why not, unless this somehow counts as a custom circuit (I doubt it).

Not sure whether this or the in-code wrapper is clunkier. Perhaps this is something wpilib could support in the future.

[Ether]

Originally Posted by Oblarg

Not sure whether this or the in-code wrapper is clunkier.

Do you want the FPGA to compute your instantaneous rate and position? Does the wrapper approach accomplish that?

[Oblarg]

Originally Posted by Ether

Do you want the FPGA to compute your instantaneous rate and position? Does the wrapper approach accomplish that?

Wrapper should accomplish this, as encoder does have both a getPosition and getRate method - it's just that you can only set it to have PIDGet() call one of them or the other.

[kylelanman]

In your code where you set a set point on your velocity PID Controller couldn't you set the encoder to kRate mode and then in the code where you set a set point on your position PID Controller couldn't you set the encoder to kDistance mode? Unless I'm misunderstanding the use case you aren't going to be running both the position and the velocity PID Controllers at the same time so this should work.

[nickbrickmaster]

I haven't tested this, and haven't read the implementation, but you may also be able to create two encoder objects, one for position and one for rate.

Clarify: with the same port numbers.

Second edit: out of curiosity, what's your use case for this?

[Oblarg]

Originally Posted by nickbrickmaster

I haven't tested this, and haven't read the implementation, but you may also be able to create two encoder objects, one for position and one for rate.

Clarify: with the same port numbers.

Second edit: out of curiosity, what's your use case for this?

I considered constructing two encoders on the same pins, but I strongly suspect this will throw an error. Will have to check.

The use case is controlling a turret - we're wondering if it's possible to do a cascading loop using the same encoder for both the external (position) loop and the internal (velocity) loop. It's probably totally unnecessary to do this (simple fixes for dealing with friction and whatnot work fine), but it's an interesting thought.

[Thad House]

Creating 2 encoder objects on the same pins technically would be allowed, as long as you used the DigitalSource constructors for the encoder, rather then the int constructor, and passed in preconstructed DigitalInput objects. However, this is overkill, as you can pass the same instance of an encoder to 2 separate PIDController objects. This would be my recommended way, as constructing 2 separate encoder objects actually takes away an encoder you could use for another purpose, whereas 2 PIDController objects with the same encoder object wouldn't take any extra resources.

[Oblarg]

Originally Posted by Thad House

Creating 2 encoder objects on the same pins technically would be allowed, as long as you used the DigitalSource constructors for the encoder, rather then the int constructor, and passed in preconstructed DigitalInput objects. However, this is overkill, as you can pass the same instance of an encoder to 2 separate PIDController objects. This would be my recommended way, as constructing 2 separate encoder objects actually takes away an encoder you could use for another purpose, whereas 2 PIDController objects with the same encoder object wouldn't take any extra resources.

Yeah, but you can't send the same encoder object to two separate PIDController objects and have it be a kRate source for one of them and kPosition source for another. Hence the wrapper idea, which is ugly but would probably work.

[Thad House]

Originally Posted by Oblarg

Yeah, but you can't send the same encoder object to two separate PIDController objects and have it be a kRate source for one of them and kPosition source for another. Hence the wrapper idea, which is ugly but would probably work.

Oh I guess thats true. A small wrapper class would allow that however, and that class should be pretty thin.

[Joe Ross]

Originally Posted by Oblarg

Yeah, but you can't send the same encoder object to two separate PIDController objects and have it be a kRate source for one of them and kPosition source for another. Hence the wrapper idea, which is ugly but would probably work.

Here's a wrapper that 2485 wrote that does this.

https://github.com/team2485/frc-2016...dDistance.java

[calcmogul]

Originally Posted by Oblarg

The use case is controlling a turret - we're wondering if it's possible to do a cascading loop using the same encoder for both the external (position) loop and the internal (velocity) loop.

If I understand your mechanism correctly, you are using both PID controllers to drive the same plant. One handles the position state while the second handles the velocity state. Velocity and acceleration feedforwards may help here. If you know what control signal you need to assert to produce a given velocity and acceleration, you could pass that information via feedforwards to a single position PID controller and remove the velocity PID controller. Otherwise, you could pass them to the inner velocity PID controller, and the velocity PID controller would, in effect, be accounting for uncertainties in your model that generates the velocity feedforward.

A custom controller that accounts for all three states (position, velocity, and acceleration) in the setpoint would be cleaner in my opinion, and the appropriate modifications to the PIDController class shouldn't be too difficult. By the way, state space controllers do this as well, but they require a reasonably accurate system model while PID does not.

[Oblarg]

Originally Posted by calcmogul

Otherwise, you could pass them to the inner velocity PID controller, and the velocity PID controller would, in effect, be accounting for uncertainties in your model that generates the velocity feedforward.

This is the idea. As I said, it's probably completely unnecessary - but I didn't see any reason why it couldn't be done, and thought it might be worth playing with.