Solenoid control

[Grizzlie]

I am trying to program the solenoids this year to wherewhen i hold the trigger it activates and when i let go it deactivates. Same as the reverse motion. I wrote this code to do this but it wont work. When i press the trigger the solonoid activates but when i let go it doesnt stop. And it WILL NOT go back when i press the rev button. heres the code i wrote :

 if (p3_sw_trig);

{              
      relay3_fwd = 1;
}

if (!p3_sw_trig);

{
      relay3_fwd = 0;
}

if (p3_sw_top);

{
      relay3_rev = 1;
}

if (!p3_sw_trig);

{
      relay3_rev = 0;
}

It would be great if someone could explain to me what i did wrong here because i'm fairly new to the C language. But it would be even better if someone could post the exact code to make this work. Thank You for even taking your time to read this post. And also good luck this year!