It’s probably lucky that it didn’t work.
You forgot to stop the elevator motors, so they would run forever.
This is in the Periodic Tasks.vi?
You needed to add in a while button is held check.
The servo would not move if it’s already at the 120 degree position.
Angles are in integer units, rather than floating point.
A half second might not be a long enough time to give a servo to move, but it ill continue to move as the elevator starts.
The last reply looks like a really good example. In case you wanted another way to do the same thing, I put another sample below. This one doesn’t block using waits. Instead it starts a timer and checks for completion to start the delayed action. (Instruction on how to make the timers and edge detection are in the book referenced above.)
In this example that you’ve shared, we see the SECRET .vi’s (Edge on, Timer Start, Timer Done?) Are these vi’s available for download? I downloaded the 2020 Secret Book Robot project, and I don’t find them there. Any help is appreciated.
While updating the book, I did create the library associated with the problems. However, I’ve been conflicted about if it is appropriate to provide this since I’m a mentor. I updated the book and added the problems for the library routines so students could learn to create these routines for themselves. I’d really like to hear the thoughts of others on this subject!!!
That being said. The EdgeOn, Time Get, Timer Start, and Is Timer Done subVIs are all fairly easy to create.
Edge On. This is problem 1.4 in the Secret book of LabVIEW 2.x) The truth table for this function can be found in Appendix A. A sample of the logic used in this subVI is found in figure 5.14. The feedback node used in this logic is described in Chapter 1.
Time Get (Used by Timer Start and Is Timer Done) , Timer Start, and Is Timer Done are described in Chapter 2, and problems 2.1, 2.2, 2.3. Compare figures 2.2 and 2.3 to get an idea of the logic that is needed for these.
Here are the steps needed to create your own subVI. (This is throughout chapter 1).
create a new VI.
On the front panel of the new subVI create the input “Controls” (in subVIs, “Controls” are inputs, “Indicators” are outputs) needed for the subVI you are making. Usually inputs are placed on the left. Double click on the default label and type a new name to change the label name.
On the front panel of the new subVI create the output “Indicators”. Usually outputs are placed on the right. Double click on the default label and type a new name to change the label name.
Now create terminals for your inputs (controls) and outputs (indicators). To do this, left click on the terminal you want to use, then left click on the control or indicator to associate with that terminal. The terminal template is shown in the right corner of the front panel.
Again inputs are on the left and outputs on the right. (This is not mandatory, but it is a lot easier
to read when the data all flows left to right.) For one input and one output the terminal template would look like this when done. (Yours may look different if you selected different locations. That is okay.)
For inputs, right click on the input terminals and select “This connection → is required” This will cause an error if you use this subVI and forget to wire an input. This will save you a lot of time debugging!!!.
Switch to the block diagram and add your logic.
Save the file. Give a name that has meaning so you can find it. Also make certain you know in what directory the file is being saved!. Best to keep the files inside the directory of your project (unless using libraries.)
Create an Icon for this subVI. On the front panel, double click the default icon to edit the icon.
Simple icons that let you know what this is are often the best. Often just the name of the function is enough.
Set the execution parameters. On the menu, select FILE, then select VI PROPERTIES.
Select the EXECUTION category and change the settings to look like this.
Save the subVI!! (I’m calling it a subVI because it can be used by other VIs. However there really isn’t a difference between VI and subVI.)
Test and use.
Hope this helps this to create these routines.
(The link to the book is above, but just in case here it is.)
For this to work, would I have to disable the elevator motors in teleop? Or remove them from teleop entirely? I tried this example in the code, but it seems like the loop doesn’t activate at all (As in, the elevator works when the button is pressed but there’s no delay and the servo doesn’t activate)
As for @JSIMPSO , that looks very interesting! I’ll definitely give it a try
You can’t command the elevator in two different places.
Both Teleop and Periodic Tasks are running at the same time, so the elevator would get conflicting orders and whatever Teleop is doing would win.
I removed the elevator stuff in teleop and it worked like a charm! Thanks!
A side note: I usually program limit switches in teleop, but since I can’t use teleop for these elevators, is there a way to do limit switches where it doesn’t interfere with periodic tasks? (EX: When DIO 1 is activated, cancel the elevator loop)
I’m away from my computer right now, so I can’t test your code.
I suggest running this through highlight execution or probing the wire values to see if the limit switch is set for the correct direction.
The way you have it assumes the limit switch is wired Normally Closed.
There are two ways the switch can work
Normally Open (returns true when not depressed)
Normally Closed (returns false when NOT depressed)
See if the limit switch value is what you think it should be.
You can add a DIO Get just in the main loop for you to watch the limit switch value without having to trigger the whole sequence.