TalonSRX isFinished() for close loop control



Hi, I am struggling on writing a simple drive by distance command using the TalonSRX close loop.

Each time the command starts it’s resetting the sensor position, setting the control mode to position and setting the setpoint.
The thing is that it’s taking time for the talon.getCloseLoopError() to return the real value and still return the old (even when using the timeoutMs=100) error which can be ~0 so the command will immediately stop.

Why there is no isFinished() if configAllowableClosedloopError() exist, am I missing something here?

Thanks in advance!


It gets the last received update from the Talon, and returns quickly. A common strategy is to servo until getClosedLoopErr() returns an acceptably small value for say 5 loops in a row.
So increment a counter if the closed loop error is small, and clear it when its large.
If counter > 5, then return true in your command’s isfinished implem.

getClosedLoopErr, does not take a timeout. It gives you the latest value received.

By default that signal group updates every 160ms. You can speed up the update rate, see here.
10ms should be good. Just keep an eye on your CAN bus Util (DS lightening tab) and keep it under 90%.

Because it is mechanism specific. You will also likely need to debounce simply because of momentum and the requirements of your mechanism. Typically you will want the mechanism/game-piece to “settle”, before moving on. But you also want to tweak this to be as fast as you can get away with (auton time, etc.).

A typically well-tuned system will overshoot slightly, and you typically want the overshoot corrected before you move on. So don’t stop the command just because one sensor sample is “close enough”.

configAllowableClosedloopError allows the MC to stop driving the motor if the target is “close enough”.
But just because the motor is not applying voltage does not mean the mechanism is settled.

Makes sense?

Some general references for posterity…
Java Pos closed loop example
Java Motion Magic example
General Documentation
Java API


Well I guess that this can be a solution, just not a “straight” one.

Yep, I meant the timeoutMs in setSelectedSensorPosition().

Well I know I can change the update rate but I didn’t want to go to that solution as the update rate will determine the correction of my command.

Well for that we just used the !isMoving() method (that exist in the navX) in the command isFinished, but i will see if using the counter solution will do the trick.