TBA match summaries for ISR District Event #1 correct?

Looking at the match summaries for ISR District Event #1, I’m confused by the presentation of the Auto Leave field. My confusion starts right with match #1, and is mostly, it seems, with red alliance results. I’m assuming the score is right and the checkmarks/Xs is the problem? Or it’s me?
Screenshot 2024-02-25 at 8.15.40 PM

2 Likes

When I go to the API and look at the same match, it does appear to be just an error in the presentation.

GET https://www.thebluealliance.com/api/v3/event/2024isde1/matches

...
      "red": {
        "adjustPoints": 0,
        "autoAmpNoteCount": 0,
        "autoAmpNotePoints": 0,
        "autoLeavePoints": 2,
        "autoLineRobot1": "No",
        "autoLineRobot2": "No",
        "autoLineRobot3": "Yes",
...

That’s for qual match 1.

Looks like a simple typo. Red 2 is being rendered twice: the-blue-alliance/src/backend/web/templates/match_partials/match_breakdown/match_breakdown_2024.html at 4c0fb248aed3fbed5d70420617f5c6bd313df051 · the-blue-alliance/the-blue-alliance · GitHub

1 Like

Pinging @Eugene_Fang

1 Like

Give me a few minutes and I’ll get it fixed.

EDIT:
PR up, just waiting for specs and reviews:

7 Likes

I think the value for tech fouls and regular fouls might be confusing as well. On the Foul/Tech Fouls line it is showing +12 for tech fouls, and +5 for regular fouls. The Total Score appears correct based on the rules for +2 fouls, +5 tech fouls.

1 Like

It looks like the Ranking Point dots are not showing up on the main event page either.

For example, Match 1 recorded 3 RP, and has the Melody Bonus dot indicating RP achieved in the specific match page (below image). This dot is not seen in the above image.

Not sure if this is the appropriate location in code or not, but this hasn’t been updated for 2024: the-blue-alliance/src/backend/web/templates/match_partials/match_table_cell_macros.html at 4c0fb248aed3fbed5d70420617f5c6bd313df051 · the-blue-alliance/the-blue-alliance · GitHub

1 Like

Good catch; I’ve fixed that as well. :+1:

2 Likes

Yep yep, you’re totally right, this does need adding as well.

The last change I made already went through, but I’ve opened another one, which should merge shortly, assuming I didn’t break any of the tests :sweat_smile:

3 Likes

I feel like Ranking Score/Match is not what we need because that is what ranking score is.

I feel like the Ranking ScorexMatch is what should be there or another word for it Total RP

5 Likes

Both of these fixes are live:

9 Likes

Thanks @Dracco for addressing the issues!

7 Likes

This is tangentially related, but in previous years there were dots next to the scores indicating the extra RPs, but I don’t see them this year.
image

1 Like

Who can spot what’s not right here?

11 Likes

I fixed these last night as well, the pages were just cached, so they weren’t displaying yet. :slight_smile:

image

3 Likes

Thanks, looks great!

2 Likes

Thanks for all these quick fixes! I’d like to make another request:

On the Insights page with the drop down of available cOPRs, could we add the following:

Auto Total Note Count
Teleop Total Note Count

I know these are just summations of existing categories and can be generated pretty easily, but it would be nice to be able to quickly pull these as they’re analogous to the traditional “cycle counts” that scouts frequently talk about. Thanks for considering! The cOPR lists are by far my favourite scouting/analysis tool on TBA.

8 Likes

I second this request. We’d like to be able to see which matches to watch to find other teams that score in the trap. Starting with the matches with the appropriate dot is a big help.

No problem!

Oh yeah, both of those are indeed really good quick stats. They’re easy enough to add, and certainly helpful, so I’ll get them added as well!

1 Like

Actually, it looks like @jtrv beat me to it, plus some extras, so that should be in there soon!

2 Likes