Victor not running motor

we are using a VictorSPX to drive our intake and it doesnt seem to be running the motor we have confirmed that it is running the push and succ methods and the LEDs indicate that it it is not moving the motor here is the subsystem we are using

/* Copyright © 2018 FIRST. All Rights Reserved. /
Open Source Software - may be modified and shared by FRC teams. The code /
must be accompanied by the FIRST BSD license file in the root directory of /
the project. /

package frc.robot.subsystems;

import edu.wpi.first.wpilibj.command.Subsystem;

import com.ctre.phoenix.motorcontrol.ControlMode;
import com.ctre.phoenix.motorcontrol.can.VictorSPX;
import frc.robot.OI;


  • Add your docs here.
    public class IntakeSubsystem extends Subsystem {
    VictorSPX SPXintake = new VictorSPX(OI.SPXintake); //defining victor
    // Put methods for controlling this subsystem
    // here. Call these from Commands.

public void succ() {
SPXintake.set(ControlMode.PercentOutput, 1); //will spin the the intake to the set ammount
public void push() {
SPXintake.set(ControlMode.PercentOutput, -1);
public void stop() {
SPXintake.set(ControlMode.PercentOutput, 0);
public void initDefaultCommand() {
// Set the default command for a subsystem here.
// setDefaultCommand(new MySpecialCommand());

Would it be possible for you to put your code on github and link it here?
Also, my team initializes our victors and talons in the subsystem constructor. Try something along the lines of :
VictorSPX SPXintake;
public IntakeSubsystem(){
SPXintake = new VictorSPX(OI.SPXintake);

I also see that you have your default command commented out. You may want to add in a default command and run your subsystem methods from there. Again, if I could see your code in its entirety I think I could be of more assistance.

Can you also please confirm that the Victor is running the latest firmware in Phoenix Tuner, and verify the device ID is what you expect.

How did you confirm that your methods are being called?

As @KeanuClark364 said, it will be much easier to troubleshoot with your whole code base, you’d be surprised how an error in a seemingly unrelated class will break something else.

I also agree it is odd your default command is commented out, perhaps you are using some other command to test?

Finally, when posting code blocks, wrap it in triple backticks so CD will format it nicely.

VictorSPX SPXintake = new VictorSPX(OI.SPXintake); //defining victor
Will display as

VictorSPX SPXintake = new VictorSPX(OI.SPXintake); //defining victor

This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.